configuration: started to implement new format

chatmastermind/ais/openai.py

@@ -17,8 +17,9 @@ class OpenAI(AI):
     The OpenAI AI client.
     """
 
-    def __init__(self, name: str, config: OpenAIConfig) -> None:
+    def __init__(self, config: OpenAIConfig) -> None:
-        self.name = name
+        self.ai_type = config.ai_type
+        self.name = config.name
         self.config = config
 
     def request(self,
@@ -31,8 +32,7 @@ class OpenAI(AI):
         chat history. The nr. of requested answers corresponds to the
         nr. of messages in the 'AIResponse'.
         """
-        # FIXME: use real 'system' message (store in OpenAIConfig)
+        oai_chat = self.openai_chat(chat, self.config.system, question)
-        oai_chat = self.openai_chat(chat, "system", question)
         response = openai.ChatCompletion.create(
             model=self.config.model,
             messages=oai_chat,

chatmastermind/configuration.py

@@ -1,6 +1,7 @@
 import yaml
+from pathlib import Path
 from typing import Type, TypeVar, Any
-from dataclasses import dataclass, asdict
+from dataclasses import dataclass, asdict, field
 
 ConfigInst = TypeVar('ConfigInst', bound='Config')
 OpenAIConfigInst = TypeVar('OpenAIConfigInst', bound='OpenAIConfig')
@@ -11,6 +12,7 @@ class AIConfig:
     """
     The base class of all AI configurations.
     """
+    ai_type: str
     name: str
 
 
@@ -19,13 +21,18 @@ class OpenAIConfig(AIConfig):
     """
     The OpenAI section of the configuration file.
     """
-    api_key: str
+    # all members have default values, so we can easily create
-    model: str
+    # a default configuration
-    temperature: float
+    ai_type: str = 'openai'
-    max_tokens: int
+    name: str = 'openai_1'
-    top_p: float
+    system: str = 'You are an assistant'
-    frequency_penalty: float
+    api_key: str = '0123456789'
-    presence_penalty: float
+    model: str = 'gpt-3.5'
+    temperature: float = 1.0
+    max_tokens: int = 4000
+    top_p: float = 1.0
+    frequency_penalty: float = 0.0
+    presence_penalty: float = 0.0
 
     @classmethod
     def from_dict(cls: Type[OpenAIConfigInst], source: dict[str, Any]) -> OpenAIConfigInst:
@@ -33,7 +40,9 @@ class OpenAIConfig(AIConfig):
         Create OpenAIConfig from a dict.
         """
         return cls(
-            name='OpenAI',
+            ai_type='openai',
+            name=str(source['name']),
+            system=str(source['system']),
             api_key=str(source['api_key']),
             model=str(source['model']),
             max_tokens=int(source['max_tokens']),
@@ -43,15 +52,24 @@ class OpenAIConfig(AIConfig):
             presence_penalty=float(source['presence_penalty'])
         )
 
+    def as_dict(self) -> dict[str, Any]:
+        return asdict(self)
+
+
+def create_default_ai_configs() -> dict[str, AIConfig]:
+    openai_conf = OpenAIConfig()
+    return {openai_conf.name: openai_conf}
+
 
 @dataclass
 class Config:
     """
     The configuration file structure.
     """
-    system: str
+    # all members have default values, so we can easily create
-    db: str
+    # a default configuration
-    openai: OpenAIConfig
+    db: str = './db/'
+    ais: dict[str, AIConfig] = field(default_factory=create_default_ai_configs)
 
     @classmethod
     def from_dict(cls: Type[ConfigInst], source: dict[str, Any]) -> ConfigInst:
@@ -59,20 +77,34 @@ class Config:
         Create Config from a dict.
         """
         return cls(
-            system=str(source['system']),
             db=str(source['db']),
-            openai=OpenAIConfig.from_dict(source['openai'])
+            ais=source['ais']  # FIXME: call correct constructors
         )
 
+    @classmethod
+    def create_default(self, file_path: Path) -> None:
+        """
+        Creates a default Config in the given file.
+        """
+        conf = Config()
+        conf.to_file(file_path)
+
     @classmethod
     def from_file(cls: Type[ConfigInst], path: str) -> ConfigInst:
         with open(path, 'r') as f:
             source = yaml.load(f, Loader=yaml.FullLoader)
+        # add the AI name to the config (for easy internal access)
+        for ai_name, ai_conf in source['ais'].items():
+            ai_conf['name'] = ai_name
         return cls.from_dict(source)
 
-    def to_file(self, path: str) -> None:
+    def to_file(self, file_path: Path) -> None:
-        with open(path, 'w') as f:
+        # remove the AI name from the config (for a cleaner format)
-            yaml.dump(asdict(self), f, sort_keys=False)
+        data = self.as_dict()
+        for ai_name, ai_conf in data['ais'].items():
+            del (ai_conf['name'])
+        with open(file_path, 'w') as f:
+            yaml.dump(data, f, sort_keys=False)
 
     def as_dict(self) -> dict[str, Any]:
         return asdict(self)