chat: 'msg_gather()' now supports globbing

- no longer using file suffix to choose the format
- added 'mformat' argument to 'write_xxx()' functions
- file suffix is now set by 'Message.to_file()' per default

chatmastermind/commands/hist.py

@@ -2,26 +2,7 @@ import argparse
 from pathlib import Path
 from ..configuration import Config
 from ..chat import ChatDB
-from ..message import MessageFilter, Message
-
-
-msg_suffix = Message.file_suffix_write
-
-
-def convert(args: argparse.Namespace, config: Config) -> None:
-    """
-    Convert messages to a new format. Also used to change the suffix,
-    to the latest default message file suffix.
-    """
-    chat = ChatDB.from_dir(Path(config.cache),
-                           Path(config.db))
-    # read all known message files
-    msgs = chat.msg_gather(loc='disk', glob='*.*')
-    # make a set of all message IDs
-    # msg_ids = set([m.msg_id() for m in msgs])
-    # set requested format and write all messages
-    chat.set_msg_format(args.format)
-    chat.msg_write(msgs)
+from ..message import MessageFilter
 
 
 def hist_cmd(args: argparse.Namespace, config: Config) -> None:

chatmastermind/commands/question.py

@@ -10,10 +10,6 @@ from ..ai_factory import create_ai
 from ..ai import AI, AIResponse
 
 
-class QuestionCmdError(Exception):
-    pass
-
-
 def add_file_as_text(question_parts: list[str], file: str) -> None:
     """
     Add the given file as plain text to the question part list.
@@ -84,12 +80,7 @@ def create_message(chat: ChatDB, args: argparse.Namespace) -> Message:
     to the cache directory.
     """
     question_parts = []
-    if args.create is not None:
-        question_list = args.create
-    elif args.ask is not None:
-        question_list = args.ask
-    else:
-        raise QuestionCmdError("No question found")
+    question_list = args.ask if args.ask is not None else []
     text_files = args.source_text if args.source_text is not None else []
     code_files = args.source_code if args.source_code is not None else []
 

tests/test_question_cmd.py

@@ -41,8 +41,6 @@ class TestMessageCreate(TestWithFakeAI):
         self.args.AI = None
         self.args.model = None
         self.args.output_tags = None
-        self.args.ask = None
-        self.args.create = None
         # File 1 : no source code block, only text
         self.source_file1 = tempfile.NamedTemporaryFile(delete=False)
         self.source_file1_content = """This is just text.
@@ -206,21 +204,6 @@ It is embedded code
 """))
 
 
-class TestCreateOption(TestMessageCreate):
-
-    def test_message_file_created(self) -> None:
-        self.args.create = ["How does question --create work?"]
-        self.args.ask = None
-        cache_dir_files = self.message_list(self.cache_dir)
-        self.assertEqual(len(cache_dir_files), 0)
-        create_message(self.chat, self.args)
-        cache_dir_files = self.message_list(self.cache_dir)
-        self.assertEqual(len(cache_dir_files), 1)
-        message = Message.from_file(cache_dir_files[0])
-        self.assertIsInstance(message, Message)
-        self.assertEqual(message.question, Question("How does question --create work?"))  # type: ignore [union-attr]
-
-
 class TestQuestionCmd(TestWithFakeAI):
 
     def setUp(self) -> None: